New regression tests for V2 surface coldstart files #2005

GeorgeGayno-NOAA · 2023-11-20T13:10:04Z

PR Author Checklist:

I have linked PR's from all sub-components involved in section below.
I am confirming reviews are completed in ALL sub-component PR's.
I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
- LOG: Baselined to my branch. RegressionTests_hera.log
I have added the list of all failed regression tests to "Anticipated changes" section.
I have filled out all sections of the template.

Description

The UFS_UTILS chgres_cube program was updated for fractional (partial land/non-land) grids and a new version of the surface coldstart file is output. This new file format will work with either fractional or non-fractional cases. Create three new regression tests that use the new file format.

Commit Message

- Add three new regression tests for version 2 of the surface coldstart file. (Closes #1977)

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Fixes New regression tests for v2 surface coldstart files #1977.

Subcomponent Pull Requests

Update i/o routines for new surface coldstart file. NOAA-EMC/fv3atm#698

Blocking Dependencies

N/A

Subcomponents involved:

Anticipated Changes

Input data

No changes are expected to input data.
Changes are expected to input data:
- New input data.
- Updated input data.

Regression Tests:

No changes are expected to any current regression test.
Changes are expected to the following tests:

Tests effected by changes in this PR:

Three new regression tests based on the existing 'control_c48', 'control_p8' and 'cpld_control_p8' tests

New coldstart files for these tests are in /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/chgres_cube.fractional/RT

control_c48.v2.sfc - ./FV3_input_data48/INPUT_L127.v2.sfc
control_p8.v2.sfc - ./FV3_input_data/INPUT_L127.v2.sfc
cpld_control_p8.v2.sfc - ./FV3_input_data/INPUT_L127_mx100.v2.sfc

New baseline files will need to be hosted for these new tests.

All regression tests passed except for the three new tests (because the new tests do not have baseline files yet).

Libraries

Not Needed
Needed
- Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
- Add issue link from JCSDA/spack-stack following this item

Code Managers Log

This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
- N/A

Testing Log:

RDHPCS
- Hera
- Orion
- Hercules
- Jet
- Gaea
- Cheyenne
WCOSS2
- Dogwood/Cactus
- Acorn
CI
- Completed
opnReqTest
- N/A
- Log attached to comment

Fixes ufs-community#1977.

cpld_control_p8 test. Fixes ufs-community#1977.

directory for v2 surface test. Fixes ufs-community#1977.

DeniseWorthen · 2023-12-18T22:35:01Z

@GeorgeGayno-NOAA We're adding a Commit Message requirement to the PRs. Please add one in the space provided.

GeorgeGayno-NOAA · 2024-02-06T12:51:10Z

@GeorgeGayno-NOAA Note that feature branch is recommended but your branch syncs ok. Then, we can move on to commit. We will try to combine in #2115 to this pr after your branch is synced up. @BrianCurtis-NOAA FYI: #2111 is combined ok into #2115

My branch looks synced up. Did you do that?

jkbk2004 · 2024-02-06T13:03:46Z

@GeorgeGayno-NOAA Note that feature branch is recommended but your branch syncs ok. Then, we can move on to commit. We will try to combine in #2115 to this pr after your branch is synced up. @BrianCurtis-NOAA FYI: #2111 is combined ok into #2115

My branch looks synced up. Did you do that?

@GeorgeGayno-NOAA I pushed a few commits to sync up. This pr is ready. Hera full test passes ok. There was a minor issue on #2115 side. The issue was fixed but we are not going to combine with any other PRs. @BrianCurtis-NOAA FYI @zach1221 @FernandoAndrade-NOAA can you pick up from here.

zach1221 · 2024-02-07T13:35:55Z

Hey, @BrianCurtis-NOAA . How are acorn/wcoss coming along?

BrianCurtis-NOAA · 2024-02-07T19:48:44Z

gnv1_nested is causing issues on WCOSS2. I've tried 2 comparisons, redid that baseline and compared against it again and it still failed in comparison. This test needs to be disabled on WCOSS2 and the developer of that test needs to find out why it isn't reproducing it's own baselines.

zach1221 · 2024-02-07T20:11:51Z

gnv1_nested is causing issues on WCOSS2. I've tried 2 comparisons, redid that baseline and compared against it again and it still failed in comparison. This test needs to be disabled on WCOSS2 and the developer of that test needs to find out why it isn't reproducing it's own baselines.

Brian, I can make an issue and make note of each machine this is occurring on.

zach1221 · 2024-02-07T20:16:48Z

The Hera ORTs should be done shortly and we can move on to start merging.

zach1221 · 2024-02-07T21:19:55Z

Testing is complete. Moving to merge the fv3atm sub-pr.

tests/fv3_conf/control_run.IN

tests/tests/control_p8.v2.sfc

GeorgeGayno-NOAA added 21 commits September 18, 2023 14:00

Update to use FV3 branch.

b3eb6fd

Update regression test log for Hera.

9bfffc1

Merge remote-tracking branch 'upstream/develop' into develop

b4c1e5d

Merge remote-tracking branch 'upstream/develop' into develop

595a573

Add new v2 surface test based on the c48 atm control test.

5c3fc7c

Merge remote-tracking branch 'upstream/develop' into develop

52b56a3

Point to my FV3ATM branch.

5e4dd8e

Add new test based on the existing control_p8 test.

684a13d

Merge remote-tracking branch 'upstream/develop' into develop

17e55e9

Point to my FV3 branch.

e9eaac4

Merge remote-tracking branch 'upstream/develop' into develop

4570117

Update FV3.

e0f426d

Merge remote-tracking branch 'upstream/develop' into develop

84cb9c3

Update to branch version of FV3

e63c5a1

Set default value of V2 surface flag variable in control_run.IN.

bd9caf5

Point to updated branch version of FV3.

2c22f57

Merge remote-tracking branch 'upstream/develop' into develop

b5eebcb

Point to updated FV3.

af9f96d

Merge remote-tracking branch 'upstream/develop' into develop

67700a5

Merge remote-tracking branch 'upstream/develop' into develop

bcdfdd0

Fixes ufs-community#1977.

Point to my FV3 branch

3658bb5

Fixes ufs-community#1977.

GeorgeGayno-NOAA mentioned this pull request Nov 20, 2023

Update chgres_cube for fractional grids ufs-community/UFS_UTILS#873

Merged

5 tasks

GeorgeGayno-NOAA added 6 commits December 4, 2023 14:50

Merge remote-tracking branch 'upstream/develop' into develop

2014ca7

Fixes ufs-community#1977.

Point to my FV3 branch.

7733e21

Fixes ufs-community#1977.

Merge remote-tracking branch 'upstream/develop' into develop

a3f7bac

Fixes ufs-community#1977.

Point to my FV3 branch.

975f012

Fixes ufs-community#1977.

Add files for new v2 surface tested based on the existing

0a1c041

cpld_control_p8 test. Fixes ufs-community#1977.

Update control file for eventual new coldstart file

4a9de4f

directory for v2 surface test. Fixes ufs-community#1977.

jkbk2004 mentioned this pull request Dec 15, 2023

p8 / p5 tag issue on gaea: CPC experiment support #1755

Closed

add hera RT log: passed

2317314

jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 6, 2024

DeniseWorthen mentioned this pull request Feb 6, 2024

Inconsistent land-sea mask among sfc*, oro* and static information files for control_p8 RT #1423

Open

zach1221 added 3 commits February 6, 2024 11:34

add hercules RT logs: passed

baa5df9

add jet RT logs: passed

45c0059

add orion RT logs: passed

b4fb66d

BrianCurtis-NOAA added 3 commits February 7, 2024 19:50

Disable gnv1_nested test on WCOSS2

840379f

WCOSS2 RT Log

4977c6a

Acorn RT Log

326bbc9

zach1221 added 3 commits February 7, 2024 21:17

add control_p8_gnu ORT logs: passed

bc69455

add regional_control_gnu ORT logs: passed

538871d

add cpld_control_gnu ORT logs: passed

b84d7f5

FV3 hash update and revert change in gitmodules

88b49e9

zach1221 requested review from jkbk2004 and BrianCurtis-NOAA February 7, 2024 21:39

jkbk2004 approved these changes Feb 7, 2024

View reviewed changes

tests/fv3_conf/control_run.IN Outdated Show resolved Hide resolved

tests/tests/control_p8.v2.sfc Outdated Show resolved Hide resolved

zach1221 requested a review from SadeghTabas-NOAA February 7, 2024 22:27

jkbk2004 requested review from FernandoAndrade-NOAA and zach1221 February 7, 2024 23:02

zach1221 approved these changes Feb 7, 2024

View reviewed changes

zach1221 merged commit 02ecf10 into ufs-community:develop Feb 7, 2024

grantfirl mentioned this pull request Mar 28, 2024

UFS-dev PR#173 NCAR/ufs-weather-model#130

Merged

ulmononian mentioned this pull request Jun 5, 2024

Integration of UFS Case Studies ICs into UFS-WM #2309

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New regression tests for V2 surface coldstart files #2005

New regression tests for V2 surface coldstart files #2005

GeorgeGayno-NOAA commented Nov 20, 2023 •

edited by zach1221

Loading

DeniseWorthen commented Dec 18, 2023

GeorgeGayno-NOAA commented Feb 6, 2024

jkbk2004 commented Feb 6, 2024

zach1221 commented Feb 7, 2024

BrianCurtis-NOAA commented Feb 7, 2024

zach1221 commented Feb 7, 2024

zach1221 commented Feb 7, 2024

zach1221 commented Feb 7, 2024

New regression tests for V2 surface coldstart files #2005

New regression tests for V2 surface coldstart files #2005

Conversation

GeorgeGayno-NOAA commented Nov 20, 2023 • edited by zach1221 Loading

PR Author Checklist:

Description

Commit Message

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

Anticipated Changes

Input data

Regression Tests:

Libraries

Testing Log:

DeniseWorthen commented Dec 18, 2023

GeorgeGayno-NOAA commented Feb 6, 2024

jkbk2004 commented Feb 6, 2024

zach1221 commented Feb 7, 2024

BrianCurtis-NOAA commented Feb 7, 2024

zach1221 commented Feb 7, 2024

zach1221 commented Feb 7, 2024

zach1221 commented Feb 7, 2024

GeorgeGayno-NOAA commented Nov 20, 2023 •

edited by zach1221

Loading